Correctly retrieve the SQL Server database version #1361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidanharan
reviewed
Oct 2, 2025
|
|
||
| def sqlserver_version | ||
| @sqlserver_version ||= _raw_select("SELECT @@version", @raw_connection).first.first.to_s | ||
| @sqlserver_version ||= execute("SELECT @@version", "SCHEMA").rows.first.first.to_s |
There was a problem hiding this comment.
AFAIK execute("SELECT @@version", "SCHEMA") will just return the number of rows affected as an integer. It won't return rows of data. I think the fix for 7.1 will be different than what is in main.
|
Closing in favor of #1363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1360. Porting changes in #1313 back to
7-1-stable. This bug impacts7.1,7.2and8.0